Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances and data types #21

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Remove instances and data types #21

merged 1 commit into from
Apr 22, 2015

Conversation

sol
Copy link
Member

@sol sol commented Apr 21, 2015

No description provided.

@sol sol changed the title Remove instances and data types Remove instances and data types (wip) Apr 21, 2015
@sol sol force-pushed the remove-instances branch 2 times, most recently from be8f236 to 0702aae Compare April 21, 2015 04:50
@sol sol changed the title Remove instances and data types (wip) Remove instances and data types Apr 21, 2015
@sol
Copy link
Member Author

sol commented Apr 21, 2015

@RyanGlScott Can you give this a review?

@RyanGlScott
Copy link
Member

  • The README changed the version of base-compat to 0.8.0. Should this also be changed in the .cabal file?
  • Since Data.Traversable.Compat was removed, we don't need to check for it in run-check.sh, right?
  • Since we no longer have GHC.Generics.Compat, I don't think we need ghc-prim as a dependency.
  • You mentioned in the .cabal file that base-compat will not add any orphan instances. Does this mean we won't reexport base-orphans instances from .Compat modules? (e.g., reexport Foldable ((,) a) from Data.Foldable.Compat.

@sol
Copy link
Member Author

sol commented Apr 21, 2015

I pushed an other commit that addresses some of your comments. Can you take an other look.

I would update the version in the cabal file before pushing to Hackage (which is hopefully soon).

I would also keep base-compat and base-orphans separate for now. If a user want's to use both, he needs one additional import. That's not ideal, but I still think the right thing until we have sorted everything out. Let's first make sure that we consolidated all orphans in base-orphans and that we get community consensus. As things currently are it would e.g. not be possible to use lens and base-compat in the same project.

@RyanGlScott
Copy link
Member

Alright, I can understand the need to be cautious about it. When I get some time (perhaps this weekend), I can do a more thorough job of going through the GHC release notes to find some more obscure orphan instances.

The rest of the pull request looks great to me.

By the way, doesn't your errorcall-eq-instance package currently reexport base-compat? It may be a good idea to redirect users to base-orphans instead from its Hacakge page. Up to you.

@sol
Copy link
Member Author

sol commented Apr 21, 2015

@RyanGlScott yes, we need to release base-orphans first and make errorcall-eq-instance depend on it + change the deprecation message, before we release base-compat-0.8.0.

@sol
Copy link
Member Author

sol commented Apr 22, 2015

I released base-orpahans and updated errorcall-eq-instance.

@sol sol merged commit 0090a6b into master Apr 22, 2015
@RyanGlScott RyanGlScott deleted the remove-instances branch May 13, 2015 15:41
phadej pushed a commit to phadej/base-compat that referenced this pull request Dec 11, 2019
…plex

Eliminate RealFloat constraint for Storable Complex instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants